Skip to content

Revert "Fix context not passed to field validators bug (#417)" #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Revert "Fix context not passed to field validators bug (#417)" #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pydantic_settings/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ def __init__(
)
)

__init__.__pydantic_base_init__ = True # type: ignore

@classmethod
def settings_customise_sources(
cls,
Expand Down
18 changes: 0 additions & 18 deletions tests/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
SecretStr,
Tag,
ValidationError,
ValidationInfo,
field_validator,
)
from pydantic import (
dataclasses as pydantic_dataclasses,
Expand Down Expand Up @@ -2774,22 +2772,6 @@ class Settings(BaseSettings):
assert s.model_dump() == {'nested': {'foo': ['one', 'two']}}


def test_validation_context():
class Settings(BaseSettings):
foo: str

@field_validator('foo')
@classmethod
def test_validator(cls, v: str, info: ValidationInfo):
context = info.context
assert context == {'foo': 'bar'}
return v

s = Settings.model_validate({'foo': 'foo bar'}, context={'foo': 'bar'})
assert s.foo == 'foo bar'
assert s.model_dump() == {'foo': 'foo bar'}


def test_nested_model_field_with_alias_choices(env):
class NestedSettings(BaseModel):
foo: List[str] = Field(alias=AliasChoices('fooalias', 'foo-alias'))
Expand Down
Loading