Skip to content

Fix alias resolution to use preferred key. #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix alias resolution to use preferred key. #481

merged 2 commits into from
Nov 27, 2024

Conversation

@kschwab
Copy link
Contributor

@kschwab kschwab commented Nov 26, 2024 •
edited
Loading

Fixes alias resolution order for EnvSettingsSource and SecretsSettingsSource.

Issue was first observed in #469. See comment for details.

@kschwab kschwab marked this pull request as ready for review November 26, 2024 14:16
@kschwab kschwab mentioned this pull request Nov 26, 2024
Closed
@hramezani
Copy link
Member

hramezani commented Nov 27, 2024

Thanks @kschwab

@hramezani hramezani merged commit a0924bc into pydantic:main Nov 27, 2024
21 checks passed
@kschwab kschwab deleted the alias-resolution-preferred-key-fix branch November 27, 2024 14:50
@kschwab kschwab mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kschwab @hramezani