-
-
Notifications
You must be signed in to change notification settings - Fork 110
Add support for GCP Secret Manager #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Change SummaryIntroduced support for Google Cloud Secret Manager integration, enhancing the ability to manage sensitive information in Pydantic settings.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
3b6828b to
472e9e1
Compare
|
@hramezani - Here's an additional source to be added for GCP manager. LMK when you want me to rebase. |
|
Thanks @ezwiefel for this PR. Please revert unrelated change in docs(you can create another PR for them) |
|
@ezwiefel please rebase. Your PR is at the top of my list. so this is the last rebase request. sorry! |
7eee671 to
a4b26c1
Compare
Apologies for that - markdown formatter got a little overzealous! 😄 For testing the new source, you'll need a GCP project and then create a Secret Version in Secret Manager. Here's a quickstart page from the docs. Doc is reverted, PR is rebased and GTG. |
|
@hramezani - Just checking in. Anything else you need from me for this PR? |
No, I need to find a time to review the PR. Unfortunately, I can't review it this week |
|
@hramezani - Thank you and no worries... I just wanted to make sure I wasn't holding you up. |
|
I left small comments. other than that LGTM |
Per hyperlint-ai suggestion Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
f55117a to
eb84f8d
Compare
|
@hramezani - Good catches - I removed the redundant tests and rebased. |
|
Thanks @ezwiefel |
Adds support for GCP Secret Manager