Skip to content

Conversation

@ezwiefel
Copy link
Contributor

Adds support for GCP Secret Manager

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 12, 2025

PR Change Summary

Introduced support for Google Cloud Secret Manager integration, enhancing the ability to manage sensitive information in Pydantic settings.

  • Added documentation for Google Cloud Secret Manager integration
  • Included installation instructions and basic usage examples
  • Outlined GCP authentication methods for accessing secrets
  • Provided important notes on secret naming and case sensitivity

Modified Files

  • docs/index.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@ezwiefel ezwiefel force-pushed the gcp-secret-manager branch from 3b6828b to 472e9e1 Compare March 12, 2025 16:25
@ezwiefel
Copy link
Contributor Author

@hramezani - Here's an additional source to be added for GCP manager. LMK when you want me to rebase.

@hramezani
Copy link
Member

Thanks @ezwiefel for this PR.

Please revert unrelated change in docs(you can create another PR for them)
Also, please let me know how I can test the new settings source(I am not familiar with GCP secret manager)

@hramezani
Copy link
Member

@ezwiefel please rebase.

Your PR is at the top of my list. so this is the last rebase request. sorry!

@ezwiefel ezwiefel force-pushed the gcp-secret-manager branch from 7eee671 to a4b26c1 Compare March 26, 2025 13:41
@ezwiefel
Copy link
Contributor Author

Thanks @ezwiefel for this PR.

Please revert unrelated change in docs(you can create another PR for them) Also, please let me know how I can test the new settings source(I am not familiar with GCP secret manager)

Apologies for that - markdown formatter got a little overzealous! 😄

For testing the new source, you'll need a GCP project and then create a Secret Version in Secret Manager. Here's a quickstart page from the docs.

Doc is reverted, PR is rebased and GTG.

@ezwiefel
Copy link
Contributor Author

@hramezani - Just checking in. Anything else you need from me for this PR?

@hramezani
Copy link
Member

@hramezani - Just checking in. Anything else you need from me for this PR?

No, I need to find a time to review the PR. Unfortunately, I can't review it this week

@ezwiefel
Copy link
Contributor Author

ezwiefel commented Apr 1, 2025

@hramezani - Thank you and no worries... I just wanted to make sure I wasn't holding you up.

@hramezani
Copy link
Member

I left small comments. other than that LGTM

@ezwiefel ezwiefel force-pushed the gcp-secret-manager branch from f55117a to eb84f8d Compare April 12, 2025 13:24
@ezwiefel
Copy link
Contributor Author

@hramezani - Good catches - I removed the redundant tests and rebased.

@ezwiefel ezwiefel changed the title Adds GCP Secret Manager source with doc and tests Add support for GCP Secret Manager Apr 12, 2025
@hramezani
Copy link
Member

Thanks @ezwiefel

@hramezani hramezani merged commit fde79e8 into pydantic:main Apr 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants