-
-
Notifications
You must be signed in to change notification settings - Fork 104
Support loading a specific nested key from YAML in YamlConfigSettingsSource #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramezani
reviewed
Apr 21, 2025
hramezani
reviewed
Apr 21, 2025
Thanks @Seunghan-Jung for the PR. I left some comments. please update |
hramezani
reviewed
Apr 21, 2025
hramezani
reviewed
Apr 21, 2025
hramezani
reviewed
Apr 21, 2025
Thanks @Seunghan-Jung |
Thanks @hramezani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be great if YamlConfigSettingsSource could support loading settings from a specific nested key within a YAML file.
Use Case
Often, YAML files contain configuration for multiple environments or sections, such as:
In this case, it would be useful to load settings from a specific key, for example, development, rather than requiring separate YAML files for each environment.
Suggested Feature
Allow an optional argument (e.g., nested_key) to be passed to YamlConfigSettingsSource like this:
This would tell the source to load settings from config["development"] instead of the root.
Benefits
• Reduces the need for multiple YAML files
• Simplifies environment-specific configuration management
• Aligns with how many existing tools and frameworks organize config