-
-
Notifications
You must be signed in to change notification settings - Fork 104
Azure Key Vault case insensitive support and dash-underscore translation #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c642e26
[FEAT] Update Azure Key Vault source: add case insensitive option and…
ololoks 96f67e4
[TEST] Add dash to underscore translation test
ololoks feaf009
[REVERT] Revert changes to env source nested alias test (separated to…
ololoks a0a444b
Merge branch 'main' into feat/azure-key-vault-upgrade
hramezani ffeb186
[CHORE] Change dash_to_underscore to False by default
d15ky f53eeec
[FIX] Update Azure KeyVault dash_to_underscore test to explicitly ena…
d15ky c0d6382
[DOCS] Add documentation for dash_to_underscore option
d15ky ca02c2b
[TEST] Update Azure KeyVault dash_to_underscore test to check the ali…
d15ky a9b7e81
[FIX] Add dash_to_underscore parameter to the example
d15ky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to pass
dash_to_underscore=True
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching it! idk how I managed to forget the main point of the example... it's fixed