fix: Respect 'cli_parse_args' from model_config with settings_customise_sources #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks for the quick PR, and nice work! |
|
Thanks @karta9821 for the PR. @trygve-baerland Can you confirm the fix? @kschwab Please review the PR when you have time. |
karta9821
force-pushed
the
fix/respect-cli-parse-args-from-model-config-with-customise-sources
branch
2 times, most recently
from
b16f436 to
8c93049
Compare
|
@hramezani This works as expected for the case I sketched in #610 . |
|
@hramezani looks good to me. Thanks for the fix @karta9821! |
hramezani
approved these changes
May 1, 2025
|
Thanks all! |
This was referenced Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #610
Selected Reviewer: @samuelcolvin