Included endpoint_url kwarg in AWSSecretsManagerSettingsSource class #664
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing and development phases, I use a `motoserver` docker container to interact with my AWS resources of my application locally.
I was able to connect with `motoserver` by using the following code:
```python
@classmethod
def settings_customise_sources(
cls,
settings_cls: type[BaseSettings],
init_settings: PydanticBaseSettingsSource,
env_settings: PydanticBaseSettingsSource,
dotenv_settings: PydanticBaseSettingsSource,
file_secret_settings: PydanticBaseSettingsSource,
) -> tuple[PydanticBaseSettingsSource, ...]:
aws_secrets_manager_settings = AWSSecretsManagerSettingsSource(
settings_cls,
secret_id=os.getenv('APP_SECRETS_MANAGER_SECRET'),
region_name=os.getenv('AWS_DEFAULT_REGION'),
endpoint_url=os.getenv('AWS_SECRETS_MANAGER_ENDPOINT'),
env_prefix='',
env_nested_delimiter='__',
case_sensitive=True,
)
return (
init_settings,
env_settings,
dotenv_settings,
file_secret_settings,
aws_secrets_manager_settings,
)
```
My proposal keeps the original behavior in the `AWSSecretsManagerSettingsSource` class and add a more complete configuration to interact with the AWS Secrets Manager provider.
hramezani
approved these changes
Aug 6, 2025
|
Thanks @adrianohrl |
|
@hramezani, is it possible to release a new version so that this new feature become available? |
I am busy these days and also waiting for some PRs. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing and development phases, I use a
motoserverdocker container to interact with my AWS resources of my application locally.I was able to connect with
motoserverby using the following code:My proposal keeps the original behavior in the
AWSSecretsManagerSettingsSourceclass and add a more complete configuration to interact with the AWS Secrets Manager provider.