-
-
Notifications
You must be signed in to change notification settings - Fork 115
Drop Python3.9 support #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kschwab we are going to drop python3.9 support. There is two tests in
Could you please review and correct them? You can find the format errors in lint CI. |
|
you can fix with 'uvx ruff check .' |
Some logic on those two tests that I mentioned above is related to Python < 3.9. It is not only about fixing some lint error. We have a Line 15 in 4433101
|
8cddfe8 to
83a91a4
Compare
|
@hramezani, is the goal to remove @pytest.mark.parametrize(
'value_gen,expected',
[
(lambda: str | int, '{str,int}'),
(lambda: list[int], 'list[int]'),
(lambda: List[int], 'List[int]'), # noqa: UP006
(lambda: list[dict[str, int]], 'list[dict[str,int]]'),
(lambda: list[str | int], 'list[{str,int}]'),
(lambda: list[str | int], 'list[{str,int}]'),
(lambda: LoggedVar[int], 'LoggedVar[int]'),
(lambda: LoggedVar[Dict[int, str]], 'LoggedVar[Dict[int,str]]'), # noqa: UP006
# Duplicate list above but with None
(lambda: str | int | None, '{str,int}'),
(lambda: list[int] | None, 'list[int]'),
(lambda: List[int] | None, 'List[int]'), # noqa: UP006
(lambda: list[dict[str, int]] | None, 'list[dict[str,int]]'),
(lambda: list[str | int] | None, 'list[{str,int}]'),
(lambda: list[str | int] | None, 'list[{str,int}]'),
(lambda: LoggedVar[int] | None, 'LoggedVar[int]'),
(lambda: LoggedVar[Dict[int, str]] | None, 'LoggedVar[Dict[int,str]]'), # noqa: UP006
],
)Currently it is used for dynamic Union creation in the test cases. Thoughts? |
@kschwab Yes, the goal is to remove |
83a91a4 to
f0fee99
Compare
Selected Reviewer: @samuelcolvin