Skip to content

Conversation

@lucascolley
Copy link
Contributor

@lucascolley lucascolley commented Jan 27, 2026

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

fixes

In [16]: sparse.asarray(sparse.GCXS.from_numpy(np.empty(0)))
Out[16]: <COO: shape=(0,), dtype=float64, nnz=0, fill_value=0.0>

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks @lucascolley!

@hameerabbasi hameerabbasi merged commit b8fdb73 into pydata:main Jan 28, 2026
16 of 18 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 19.94%

Comparing lucascolley:asarray-default (ac5785d) with main (67be471)

Summary

❌ 1 regressed benchmark
βœ… 339 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_index_fancy[side=100-rank=1-format='coo'] 748.3 ¡s 934.6 ¡s -19.94%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants