ENH: n-D SciPy COO interop #919
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
commented
Jan 27, 2026
Comment on lines
-454
to
+455
| coords = np.empty((2, x.nnz), dtype=x.row.dtype) | ||
| coords[0, :] = x.row | ||
| coords[1, :] = x.col | ||
| return COO( | ||
| coords, | ||
| x.coords, |
Contributor
Author
There was a problem hiding this comment.
maybe x.coords doesn't exist for coo_matrix?
Collaborator
There was a problem hiding this comment.
It doesn't, indeed. I think we might need to specialize for coo_matrix vs coo_array.
Collaborator
There was a problem hiding this comment.
Something like:
def coords(x):
c = getattr(x, "coords", None)
if c is None:
c = (x.row, x.col)
return c
Comment on lines
-1194
to
+1188
| result = scipy.sparse.coo_matrix((self.data, (self.coords[0], self.coords[1])), shape=self.shape) | ||
| result = scipy.sparse.coo_array((self.data, self.coords), shape=self.shape) |
Contributor
Author
There was a problem hiding this comment.
obviously this is a breaking change, this diff is just for demonstration
Collaborator
There was a problem hiding this comment.
I'm willing to accept this breakage given that *_array is now recommended over *_matrix.
In fact, I'd change it in all formats, not just this one, for consistency.
lucascolley
commented
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.