Skip to content

Get ASV Benchmarks running again #10556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Jul 21, 2025

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

#10355 (comment)
#10512

@Illviljan Illviljan added the run-benchmark Run the ASV benchmark workflow label Jul 21, 2025
@Illviljan Illviljan changed the title Update asv.conf.json Get ASV Benchmarks running again Jul 21, 2025
@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Jul 23, 2025
@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file labels Aug 3, 2025
@keewis
Copy link
Collaborator

keewis commented Aug 3, 2025

there's something really weird going on: somewhere in the failing CI there's a ImportError because of collections.Iterable (removed in python 3.10), triggered from sparse/coo.py which has not existed since sparse=0.3.1.

However, even pinning sparse doesn't really help, locally I always get broken environments (something about __glibc not being available). So I don't really know how to fix this.

@Illviljan
Copy link
Contributor Author

Hitting pypa/setuptools#4993 while trying to install Xarray in the benchmark environment.

I fixed it in pyproject by bumping setuptools version but for the benchmarks it builds in no isolation mode. I reverted license to the old format in pyproject.

Looks like numpy 2.2 (pin required because numba doesn't support numpy 2.3 yet) requires an old version of setuptools that doesn't work with the license entry in pyproject.

#10355 (comment)

I was hoping if we can install numpy 2.3 it will work better?

@keewis
Copy link
Collaborator

keewis commented Aug 4, 2025

does numpy still use setuptools? I thought they switched to meson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation CI Continuous Integration tools dependencies Pull requests that update a dependency file run-benchmark Run the ASV benchmark workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants