Fix ds.merge to prevent altering original object depending on join value
#10596
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcherian I am taking a look and will report back findings. |
|
Thanks! we have had this kind of issue before: #10330 Maybe a helper function is in order |
|
#7736 mentions regression so we will want to make sure that we don't solve this by just copying aggressively. |
|
Thanks for the pointer to #10330! I just took that logic and moved it outside the if block so that everybody has to go through it. I think the remaining tests are the same that are failing on main. |
|
See #10599 for fixes to doctests and mypy. |
|
It would probably be a good idea to run benchmarks on this PR. |
jsignell
changed the title
ds.merge can alter original object depending on join valueds.merge to prevent altering original object depending on join value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far this PR just adds some tests demonstrating howUsing certain join values ("exact" and "override") onmergecan alter the original objects.I discovered this in the context of #10062 (comment) but it's not really related to changes in that PR.
Closes #xxxxwhats-new.rstNew functions/methods are listed inapi.rst