Skip call to .tolist() when creating pd.Index
#10619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
`np.tile` returns an NDArray and there is no need to convert this to a Python `list` prior to passing it to `pd.MultiIndex`. The interface to Pandas requires the object to be array-like, and one of the first things that the constructor does is coerce the list back to an NDArray. For arrays with large coordinate axes, `to_dataframe()` is extremely slow due to Pandas needing to iterate through a `list` object rather than an array. For an (1000, 500, 20) array -- 10M rows in the cartesian product -- this results in a ~20x speed-up for `xr.Dataset.to_dataframe()` (tested on x86 and Apple Silicon). ```python da = xr.DataArray(np.ones((1000, 500, 20)), name="foo") da.to_dataframe() ``` Closes pydata#10617
y4n9squared
force-pushed
the
faster-to-dataframe
branch
from
81a836e to
24bfcc9
Compare
dcherian
approved these changes
Aug 13, 2025
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.tilereturns an NDArray and there is no need to convert this to a Pythonlistprior to passing it topd.MultiIndex. The interface to Pandas requires the object to be array-like, and one of the first things that the constructor does is coerce the list back to an NDArray.For arrays with large coordinate axes,
to_dataframe()is extremely slow due to Pandas needing to iterate through alistobject rather than an array.For an (1000, 500, 20) array -- 10M rows in the cartesian product -- this results in a ~20x speed-up for
xr.Dataset.to_dataframe()(tested on x86 and Apple Silicon).tolist()when constructing pandas MultiIndex? #10617