Fix unreleased bug in DataTree.to_zarr() with mode='r+' #10685
Merged
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing to zarr with `mode='r+'` was broken by pydata#10625, due to a Zarr bug (zarr-developers/zarr-python#3428). This add a work-around that works on older versions of Zarr. The PR that introduced this bug has not yet appeared in an xarray release, so there's no need for a release note.
github-actions
bot
added
the
topic-DataTree
|
There are failures with mypy-upstream-dev, but those are all unrelated to this change. |
this action is always failing :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to zarr with
mode='r+'was broken by #10625, due to a Zarr bug (zarr-developers/zarr-python#3428). This add a work-around that works on older versions of Zarr.The PR that introduced this bug has not yet appeared in an xarray release, so there's no need for a release note.