Skip to content

Add assert to CombinedLock #10787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add assert to CombinedLock #10787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9925ae
Add assert to CombinedLock
dschwoerer Sep 24, 2025
f124da3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions xarray/backends/locks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,9 @@ def __init__(self, locks: Sequence[Lock]):
self.locks = tuple(set(locks)) # remove duplicates

def acquire(self, blocking=True):
assert blocking, (
"Without blocking you will never know which locks you have to unlock!"
)
return all(acquire(lock, blocking=blocking) for lock in self.locks)

def release(self):
Expand Down
Loading