-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use cumsum from flox #10987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Illviljan
wants to merge
145
commits into
pydata:main
Choose a base branch
from
Illviljan:cumsum_flox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use cumsum from flox #10987
+750
−274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dcherian
reviewed
Dec 6, 2025
dcherian
reviewed
Dec 6, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dcherian
reviewed
Dec 6, 2025
Co-authored-by: Deepak Cherian <[email protected]>
Contributor
Author
|
@dcherian, this is ready for a another review now. It was only changes in tests since the last time. |
Contributor
|
Are you able to address the extra testing requested in #10987 (comment)? If you're too busy, we can just merge. This is a good improvement. |
for more information, see https://pre-commit.ci
This reverts commit eff5561.
for more information, see https://pre-commit.ci
Contributor
Author
|
Writing down these flox issues before I forget: ds = xr.Dataset(
{
"foo": (
("test", "time"),
[[7, 2, 0, 1, 2, np.nan], [1, 1, 1, 1, 1, 1], [2, 2, 2, 2, 2, 2]],
)
},
coords={
"time": [0, 1 / 6, 2 / 6, 3 / 6, 4 / 6, 5 / 6],
"test": ["a", "b", "b"],
"group_idx": ("time", [0, 0, 1, 1, 2, 2]),
"group_idx2": ("time", [0, 1, 1, 1, 1, 1]),
},
)
# group_idx along 1 dim and cumsum dim along another fails with flox:
ds.groupby("group_idx").cumsum("test")
# cumsum along multple dims fails with flox:
ds.groupby("group_idx").cumsum(...) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-benchmark
Run the ASV benchmark workflow
topic-DataTree
Related to the implementation of a DataTree class
topic-groupby
topic-performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstThe non-flox version reduces chunksizes significantly:
With flox the chunksize is retained:
Other changes:
Notes
groupby_scanwas added in: https://github.com/xarray-contrib/flox/releases/tag/v0.9.9cumsumwas added in: https://github.com/xarray-contrib/flox/releases/tag/v0.10.5