-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
End of deprecation cycle: default to using new combine kwargs #11076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am debating whether to make By making it a no-op I don't mean removing the option, just enforcing that if it's set it is True. This would allow us to remove some code and warnings as well as the tests that exercise the option. |
xarray/util/deprecation_helpers.py
Outdated
| return ( | ||
| f"In a future version of xarray the default value for {self._name} will " | ||
| f"change from {self._name}={self._old!r} to {self._name}={self._new!r}. " | ||
| f"In xarray v2026.02.1 the default value for {self._name} " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should put the specific version in this message, but this is just a guess at what that version will be.
|
This change had a big blast radius (every user using |
Yeaaahh fair enough. |
|
Actually I'm going to open a new PR with the docstring and test changes that I would like to salvage. |
It's been almost 6 months and I haven't seen any reports of issues. All the original PR (#10062) did was raise
FutureWarningsthough, so this could still have an impact on people who ignored those.whats-new.rstNew functions/methods are listed inapi.rst