Skip to content

Conversation

@jsignell
Copy link
Member

@jsignell jsignell commented Jan 8, 2026

It's been almost 6 months and I haven't seen any reports of issues. All the original PR (#10062) did was raise FutureWarnings though, so this could still have an impact on people who ignored those.

@jsignell
Copy link
Member Author

jsignell commented Jan 8, 2026

I am debating whether to make use_new_combine_kwarg_defaults a no-op. On the one hand it is a useful testing loop to run your combine logic with the old defaults and the new defaults and figure out if there are any differences. On the other hand what if people just set it to False and never change it?

By making it a no-op I don't mean removing the option, just enforcing that if it's set it is True. This would allow us to remove some code and warnings as well as the tests that exercise the option.

return (
f"In a future version of xarray the default value for {self._name} will "
f"change from {self._name}={self._old!r} to {self._name}={self._new!r}. "
f"In xarray v2026.02.1 the default value for {self._name} "
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put the specific version in this message, but this is just a guess at what that version will be.

@dcherian
Copy link
Contributor

dcherian commented Jan 9, 2026

This change had a big blast radius (every user using open_mfdataset!); so I propose we wait another 6 months.

@jsignell
Copy link
Member Author

jsignell commented Jan 9, 2026

This change had a big blast radius (every user using open_mfdataset!); so I propose we wait another 6 months.

Yeaaahh fair enough.

@jsignell
Copy link
Member Author

jsignell commented Jan 9, 2026

Actually I'm going to open a new PR with the docstring and test changes that I would like to salvage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stricter defaults for concat, combine, open_mfdataset, merge

2 participants