cf-coding#7654

Closed

kmuehlbauer wants to merge 22 commits intopydata:mainfrom

kmuehlbauer:preserve-bool-dtype

Commits on Apr 4, 2023

implement coders, adapt tests
kmuehlbauer
committed
preserve boolean-dtype within encoding, adapt test
kmuehlbauer
committed
determine cf packed data dtype, adapt tests
kmuehlbauer
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
kmuehlbauer
committed
fix typing, fix if-clauses, add link to issue
kmuehlbauer
committed
add comment ass per review
kmuehlbauer
committed
choose float64 if add_offset is not up to cf expectations
kmuehlbauer
committed
use scale_factor/add_offset in tests as specified by cf conventions
kmuehlbauer
committed
add test which checks add_offset being not conforming to cf standards
kmuehlbauer
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
kmuehlbauer
committed
convert to float32 to keep #1840 in sync
kmuehlbauer
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
kmuehlbauer
committed
add more comments, add more typing
kmuehlbauer
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
kmuehlbauer
committed
add additional test, make _choose_float_dtype more explicit
kmuehlbauer
committed
Apply suggestions from code review

kmuehlbauer
and
Illviljan
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks

pre-commit-ci[bot]
authored and
kmuehlbauer
committed
Apply suggestions from code review

kmuehlbauer
and
Illviljan
committed
Test against None, as 0 (False) is a valid input for add_offset. Check for float32/64 only.
kmuehlbauer
committed
apply astype in the right order to prevent loss of precision, more fillvalue fixes
kmuehlbauer
committed
add mask/scale roundtrip test for variable cf encoding/decoding
kmuehlbauer
committed
separate CFMaskCoder test for multiple missing_values/__FillValues conflict, use _FillValue for missing_value if available
kmuehlbauer
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

cf-coding#7654

cf-coding#7654
kmuehlbauer wants to merge 22 commits intopydata:mainfrom
kmuehlbauer:preserve-bool-dtype

Commits on Apr 4, 2023

implement coders, adapt tests

preserve boolean-dtype within encoding, adapt test

determine cf packed data dtype, adapt tests

[pre-commit.ci] auto fixes from pre-commit.com hooks

fix typing, fix if-clauses, add link to issue

add comment ass per review

choose float64 if add_offset is not up to cf expectations

use scale_factor/add_offset in tests as specified by cf conventions

add test which checks add_offset being not conforming to cf standards

[pre-commit.ci] auto fixes from pre-commit.com hooks

convert to float32 to keep #1840 in sync

[pre-commit.ci] auto fixes from pre-commit.com hooks

add more comments, add more typing

[pre-commit.ci] auto fixes from pre-commit.com hooks

add additional test, make _choose_float_dtype more explicit

Apply suggestions from code review

[pre-commit.ci] auto fixes from pre-commit.com hooks

Apply suggestions from code review

Test against None, as 0 (False) is a valid input for add_offset. Check for float32/64 only.

apply astype in the right order to prevent loss of precision, more fillvalue fixes

add mask/scale roundtrip test for variable cf encoding/decoding

separate CFMaskCoder test for multiple missing_values/__FillValues conflict, use _FillValue for missing_value if available

Uh oh!

cf-coding#7654kmuehlbauer wants to merge 22 commits intopydata:mainpydata/xarray:mainfrom kmuehlbauer:preserve-bool-dtypekmuehlbauer/xarray:preserve-bool-dtypeCopy head branch name to clipboard

Commits

Commits on Apr 4, 2023

cf-coding#7654
kmuehlbauer wants to merge 22 commits intopydata:mainfrom
kmuehlbauer:preserve-bool-dtype