Open
Conversation
Author
|
PR was open for 5 months, but should be an easy one to merge. Let me know if I can help with anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug in `torch_geometric.utils.softmax
If the
output_sizeargument is not provided intorch.repeat_interleave, then theoutput_sizeis calculated on the fly, at the cost of a stream synchronization, see https://docs.pytorch.org/docs/stable/generated/torch.repeat_interleave.html. But if thetorch_geometric.utils.softmaxfunction gets theindexargument in addition toptr, we getoutput_sizefor free - so we should use it.Proposed fix
When
ptrandindexare both provided intorch_geometric.utils.softmax, useindexto set theoutput_sizeintorch.repeat_interleave. Added a unit test for this case.