Add conditional skip to testSavePaletteAsPNG8 #3476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MightyJosip
approved these changes
Jun 6, 2025
Starbuck5
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our unit tests currently fail when SDL2_image doesn't use the libpng backend.
I opened 2 PRs on SDL2_image to fix most of these fails (libsdl-org/SDL_image#560 and libsdl-org/SDL_image#559) but there's still one remaining test that just cannot be fixed easily with the miniz backend (the backend that SDL2_image uses when libpng isn't used). This test tests that PNG images with a palette are saving retaining the exact same palette in the PNG.
For now I will just add a conditional skip in the same style that we use for a few of our mixer/music tests.