Refactor how the present_method is selected #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with #138. The logic surrounding the selection of the
present_methodwas not great, with some backends taking the argument in their__init__to handle it. Now the base class handles it uniformly. Nevertheless, the backend eventually decides what method is selected, and it is clearly defined when this happens, so the backend can make preparations. E.g. if Qt uses 'bitmap', the winid is not even queried.Very concrete:
canvas._rc_get_present_methods()->_rc_present_info(present_methods)