operations/files.block: correct behaviour when markers/block not found and no line provided#1419
Merged
Fizzadar merged 1 commit intopyinfra-dev:3.xfrom Sep 16, 2025
Merged
Conversation
morrison12
changed the title
Fizzadar
approved these changes
Sep 11, 2025
Member
Fizzadar
left a comment
Fizzadar
left a comment
There was a problem hiding this comment.
Really nice, thank you @morrison12!
…ne (so adding at start or end of file). Also correct mode and owner preservation
Fizzadar
force-pushed
the
issue-1416
branch
from
b0ab535 to
3fe6aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1416 so that if we're adding at the end of a file it is done correctly.
Added note in the documentation about default umask being used when files creatd
Also correct mode and owner preservation and suppressing backups when the file does not exist.
Apologies for multiple fixes in one PR.
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)