Skip to content

exclude _chdir from global arguments used when removing temporary file (fix #1426) #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

exclude _chdir from global arguments used when removing temporary file (fix #1426) #1429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1968ead
exclude _chdir from global arguments used when removing temporary file
morrison12 Aug 12, 2025
5df58ff
really use rm_arguments
morrison12 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pyinfra/connectors/ssh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,14 +517,19 @@ def put_file(
logger.error("File upload error: {0}".format(output.stderr))
return False

rm_arguments = arguments.copy()
# _chdir is the only one of the global arguments that could require _sudo to succeed
# and _sudo isn't present in arguments as removed above
rm_arguments.pop("_chdir", False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears unused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was me getting interrupted I think 😒


# Delete the temporary file now that we've successfully copied it
command = StringCommand("rm", "-f", temp_file)

status, output = self.run_shell_command(
command,
print_output=print_output,
print_input=print_input,
**arguments,
**rm_arguments,
)

if status is False:
Expand Down