Skip to content

Fix crontab modification not properly relying on the cron_name parameter #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Fix crontab modification not properly relying on the cron_name parameter #1436

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb099d
fix(operations/crontab): only provide command if cron_name is not pro…
information-redacted Aug 19, 2025
47c3c76
fix(operations/crontab): lint + remove list comprehension from inline if
information-redacted Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pyinfra/operations/crontab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ def comma_sep(value):
ctb = ctb0
name_comment = "# pyinfra-name={0}".format(cron_name)

existing_crontab = ctb.get_command(command=command, name=cron_name)
existing_crontab = ctb.get_command(
command=command if cron_name is None else None, name=cron_name
)
existing_crontab_command = existing_crontab["command"] if existing_crontab else command
existing_crontab_match = existing_crontab["command"] if existing_crontab else command

Expand Down
Loading