Skip to content

Comments

Introduce ruff for linting and formatting#1455

Merged
Fizzadar merged 2 commits intopyinfra-dev:3.xfrom
DonDebonair:feat/ruff
Sep 25, 2025
Merged

Introduce ruff for linting and formatting#1455
Fizzadar merged 2 commits intopyinfra-dev:3.xfrom
DonDebonair:feat/ruff

Conversation

@DonDebonair
Copy link
Contributor

This PR introduces ruff for linting and formatting and ditches isort, flake8 and black in the process.

The PR consists of 2 commits. The first commit contains all the needed changes (incl. documentation and CI) and the second commit makes formatting changes through ruff. Ruff is supposed to be a drop-in replacement for black, but there are still some subtle changes that cause reformats of a bunch of files.

Once this PR has been merged and we know the commit hash of the 2nd commit, I'll make a PR to add that commit to .git-blame-ignore-revs

  • Pull request is based on the default branch (3.x at this time)
  • Pull request includes tests for any new/updated operations/facts
  • Pull request includes documentation for any new/updated operations/facts
  • Tests pass (see scripts/dev-test.sh)
  • Type checking & code style passes (see scripts/dev-lint.sh)

@DonDebonair DonDebonair marked this pull request as ready for review September 21, 2025 14:26
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you @DonDebonair!

fyi I will add the reformat commit to https://github.com/pyinfra-dev/pyinfra/blob/3.x/.git-blame-ignore-revs post merge

@Fizzadar Fizzadar merged commit b1dc723 into pyinfra-dev:3.x Sep 25, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants