Added a line to clear the memoization cache before setting up the mock#1466
Merged
Fizzadar merged 2 commits intopyinfra-dev:3.xfrom Oct 1, 2025
Merged
Added a line to clear the memoization cache before setting up the mock#1466Fizzadar merged 2 commits intopyinfra-dev:3.xfrom
Fizzadar merged 2 commits intopyinfra-dev:3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that the test_get_sftp_fail test was failing because of a memoization cache problem. The get_file_transfer_connection method in the SSH connector is decorated with @memoize, which caches the result of the method call. When running multiple tests, if the method was successfully called in a previous test, it would return the cached result instead of executing again and potentially raising the expected SSHException
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)