facts.apt.update: fix computation of cache_time when host is not UTC#1504
Merged
Fizzadar merged 1 commit intopyinfra-dev:3.xfrom Dec 2, 2025
Merged
Conversation
philippemilink
force-pushed
the
fix-apt-update-cache-with-timezone
branch
2 times, most recently
from
0b1a93a to
e50913f
Compare
And reorganize a bit the logic to gather the Date fact only if required.
philippemilink
force-pushed
the
fix-apt-update-cache-with-timezone
branch
from
e50913f to
ed470cb
Compare
Fizzadar
approved these changes
Dec 2, 2025
Member
Fizzadar
left a comment
Fizzadar
left a comment
There was a problem hiding this comment.
Thank you for the PR, @philippemilink! Nice fix and a test too 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And reorganize a bit the logic to gather the Date fact only if required.
The timezone of my hosts are set on UTC+1. I noticed that the operation
apt.updatewas always executed, even when thecache_timeparameter was supposed to make it a noop. See the comment in the code for an explanation of the problem.3.xat this time)scripts/dev-test.sh) => let's see the result of the CIscripts/dev-lint.sh)