[INF] Simplify environment #1133
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,54 +2,43 @@ name: pyjanitor-dev | |
| channels: | ||
| - conda-forge | ||
| dependencies: | ||
| - python>=3.6 | ||
| # required | ||
| - pandas | ||
| - pandas-flavor | ||
| - multipledispatch | ||
| - scipy | ||
|
There was a problem hiding this comment.
|
||
| # optional | ||
| - biopython | ||
| - natsort | ||
| - pyspark>=3.2.0 | ||
| - rdkit | ||
| - tqdm | ||
| - unyt | ||
| - xarray | ||
| # io | ||
| - openpyxl | ||
| - xlrd | ||
|
|
||
| # testing | ||
| - pytest | ||
| - pytest-cov | ||
| - pytest-xdist | ||
| - hypothesis | ||
| - pandas-vet | ||
| - interrogate | ||
Zeroto521 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # dev tools | ||
| - pip-compile | ||
| - pre-commit | ||
| - pylint | ||
| - isort | ||
|
There was a problem hiding this comment. We could drop There was a problem hiding this comment. Having There was a problem hiding this comment. I already keep IDE code style checking packages (black, pylint, isort) There was a problem hiding this comment. I also made a PR #1231 making similar changes. I agree with keeping black/isort, for pylint: we don't enforce it via pre-commit, instead we use flake8 as our main linting tool. So I don't see the need for keeping it around. |
||
Zeroto521 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - make | ||
| # release | ||
| - twine | ||
|
There was a problem hiding this comment. I thought we could drop |
||
|
|
||
| # doc build | ||
| - mkdocs | ||
| - mkdocs-material | ||
| - mkdocstrings<0.18.0 | ||
| - ipython | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now minimal python version is 3.6
It may don't work in py3.6 with pandas 1.4.1.
it will be updated after setting
ci/envmulti-envsUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pandas minimum python version is 3.8, I feel we should make it that, or at least 3.7 because of dictionary order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
py3.6 base on setup.py.
As you said, this is the reason I want to build multi-envs
we could test pyjanitor compatible with python3.6 after
ci/env/was built.pyjanitor/setup.py
Line 124 in 1908f35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samukweku @Zeroto521 thanks for doing the PR and reviewing!
I think @samukweku's suggestion makes sense here. With
pandasminimum version being 3.8, we should just follow along. I thinksetup.pyshould be updated.