Skip to content

[BUG] address issue #1201 #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 27, 2022
Merged

[BUG] address issue #1201 #1203

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2379908
address issue #1201
xujiboy Nov 19, 2022
ccdcdca
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 19, 2022
d7a16cf
Merge branch 'dev' into hot_fix_issue_1201
ericmjl Nov 24, 2022
1f3fe2f
Add @joranbeasley for contributions
ericmjl Nov 24, 2022
2f1dbb7
Update AUTHORS.md
ericmjl Nov 24, 2022
e17a4ab
Update utils.py
samukweku Nov 26, 2022
359bb10
Update utils.py
samukweku Nov 26, 2022
ad2b496
Update conditional_join.py
samukweku Nov 26, 2022
31e1edd
Update conditional_join.py
samukweku Nov 26, 2022
7bed1bc
Update utils.py
samukweku Nov 26, 2022
33afc96
Update utils.py
samukweku Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,4 @@ Contributors
- [@apatao](https://github.com/apatao) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%3Aapatao)
- [@OdinTech3](https://github.com/OdinTech3) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/pull/1094)
- [@asmirnov69](https://github.com/asmirnov69) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues/1059)
- [@xujiboy](https://github.com/xujiboy) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues/1201)
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## [Unreleased]

- [BUG] address the `TypeError` when importing v0.24.0 (issue #1201 @xujiboy)

## [v0.24.0] - 2022-11-12

- [ENH] Add lazy imports to speed up the time taken to load pyjanitor (part 2)
Expand Down
4 changes: 2 additions & 2 deletions janitor/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import os
import sys
import socket
from typing import Callable, Dict, Iterable, Union
from typing import Callable, Dict, Iterable, Union, List
from functools import singledispatch, wraps
from warnings import warn

Expand Down Expand Up @@ -213,7 +213,7 @@ def idempotent(func: Callable, df: pd.DataFrame, *args, **kwargs):


def deprecated_kwargs(
*arguments: list[str],
*arguments: List[str],
message: str = (
"The keyword argument '{argument}' of '{func_name}' is deprecated."
),
Expand Down