Skip to content

Restore tests for ByteString in 3.14 #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Restore tests for ByteString in 3.14 #2829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion astroid/brain/brain_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class {0}(metaclass=Meta):
"typing.MutableMapping",
"typing.Sequence",
"typing.MutableSequence",
"typing.ByteString", # removed in 3.14
"typing.ByteString", # scheduled for removal in 3.17
"typing.Tuple",
"typing.List",
"typing.Deque",
Expand Down
10 changes: 3 additions & 7 deletions tests/brain/test_brain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from astroid import MANAGER, builder, nodes, objects, test_utils, util
from astroid.bases import Instance
from astroid.brain.brain_namedtuple_enum import _get_namedtuple_fields
from astroid.const import PY312_PLUS, PY313_PLUS, PY314_PLUS
from astroid.const import PY312_PLUS, PY313_PLUS
from astroid.exceptions import (
AttributeInferenceError,
InferenceError,
Expand Down Expand Up @@ -181,7 +181,7 @@ def check_metaclass_is_abc(node: nodes.ClassDef):
if PY312_PLUS and node.name == "ByteString":
# .metaclass() finds the first metaclass in the mro(),
# which, from 3.12, is _DeprecateByteStringMeta (unhelpful)
# until ByteString is removed in 3.14.
# until ByteString is removed in 3.17.
# Jump over the first two ByteString classes in the mro().
check_metaclass_is_abc(node.mro()[2])
else:
Expand Down Expand Up @@ -285,9 +285,6 @@ class Derived(collections.abc.Iterator[int]):
],
)

@pytest.mark.skipif(
PY314_PLUS, reason="collections.abc.ByteString was removed in 3.14"
)
def test_collections_object_subscriptable_3(self):
"""With Python 3.9 the ByteString class of the collections module is subscriptable
(but not the same class from typing module)"""
Expand Down Expand Up @@ -870,9 +867,8 @@ class Derived(typing.Hashable, typing.Iterator[int]):
],
)

@pytest.mark.skipif(PY314_PLUS, reason="typing.ByteString was removed in 3.14")
def test_typing_object_notsubscriptable_3(self):
"""Until python39 ByteString class of the typing module is not
"""The ByteString class of the typing module is not
subscriptable (whereas it is in the collections' module)"""
right_node = builder.extract_node(
"""
Expand Down
Loading