- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 305
 
          Fix a false positive for not-an-iterable in Pylint.
          #2830
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    Fix a false positive for not-an-iterable in Pylint.
  
  #2830
              Conversation
β¦ context. Closes pylint-dev/pylint#8985 Closes pylint-dev/pylint#10558
| 
           I'm never terribly confident when touching the astroid codebase but it seems to fix the issue at least!  | 
    
for more information, see https://pre-commit.ci
          Codecov Reportβ
 All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main    #2830   +/-   ##
=======================================
  Coverage   93.35%   93.36%           
=======================================
  Files          91       91           
  Lines       11113    11119    +6     
=======================================
+ Hits        10375    10381    +6     
  Misses        738      738           
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 π New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not terribly confident when reviewing astroid, but... LGTM :)
Co-authored-by: Pierre Sassoulas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably mention the fact that we now correctly support the exceptions attribute for ExceptionGroup instead, as that is the real astroid future. But I don't mind too much, so feel free to merge!
Mention what is newly supported in Astroid. Co-authored-by: DaniΓ«l van Noord <[email protected]>
          
 I'll take your advice! Do you like the wording now?  | 
    
Type of Changes
Description
Fix a false positive for
not-an-iterablein anExceptionGroupcontext.Refs #XXXX
Closes pylint-dev/pylint#8985
Closes pylint-dev/pylint#10558