- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 305
 
Extend constraints to support ternary expressions #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov Reportβ
 All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main    #2836   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files          92       92           
  Lines       11148    11148           
=======================================
  Hits        10409    10409           
  Misses        739      739           
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 π New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great !
| 
           (Changed closes to refs in the PR description so that we close the related pylint issue only when we add a test case for it after upgrading astroid)  | 
    
| 
           got it, shall we do the same for change log as well?  | 
    
| 
           No, it's only for the github side where it's tricky to remember to add automated test if we close as soon as it's fixed in astroid.  | 
    
Type of Changes
Description
Currently constraints are only applied to regular
Ifstatements, this is a minor change to support ternary expressions as well. It is expected to have identical behavior asIf.Refs pylint-dev/pylint#9729