Skip to content

Move object dunders from FunctionModel to ObjectModel #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Move object dunders from FunctionModel to ObjectModel #2847

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aeedd50
Add missing operators in FunctionModel
emmanuel-ferdman Oct 4, 2025
50a56f8
Move object dunders from `FunctionModel` to `ObjectModel`
emmanuel-ferdman Oct 5, 2025
b691e28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 5, 2025
1bc57c5
Move object dunders from `FunctionModel` to `ObjectModel`
emmanuel-ferdman Oct 5, 2025
2762ac9
Move object dunders from `FunctionModel` to `ObjectModel`
emmanuel-ferdman Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions astroid/interpreter/objectmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,22 +467,28 @@ def attr___ne__(self):
attr___subclasshook__ = attr___ne__
attr___str__ = attr___ne__
attr___sizeof__ = attr___ne__
attr___setattr___ = attr___ne__
attr___setattr__ = attr___ne__
attr___repr__ = attr___ne__
attr___reduce__ = attr___ne__
attr___reduce_ex__ = attr___ne__
attr___lt__ = attr___ne__
attr___le__ = attr___ne__
attr___eq__ = attr___ne__
attr___ge__ = attr___ne__
attr___gt__ = attr___ne__
attr___format__ = attr___ne__
attr___delattr___ = attr___ne__
attr___delattr__ = attr___ne__
attr___getattribute__ = attr___ne__
attr___hash__ = attr___ne__
attr___dir__ = attr___ne__
attr___call__ = attr___ne__
attr___class__ = attr___ne__
attr___closure__ = attr___ne__
attr___code__ = attr___ne__
attr___builtins__ = attr___ne__
attr___getstate__ = attr___ne__
attr___init_subclass__ = attr___ne__
attr___type_params__ = attr___ne__


class ClassModel(ObjectModel):
Expand Down
22 changes: 14 additions & 8 deletions tests/test_object_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,13 @@ def test_module_model(self) -> None:
xml.__setattr__ #@
xml.__reduce_ex__ #@
xml.__lt__ #@
xml.__le__ #@
xml.__eq__ #@
xml.__ne__ #@
xml.__ge__ #@
xml.__gt__ #@
xml.__format__ #@
xml.__delattr___ #@
xml.__delattr__ #@
xml.__getattribute__ #@
xml.__hash__ #@
xml.__dir__ #@
Expand Down Expand Up @@ -326,7 +329,7 @@ def test_module_model(self) -> None:

# The following nodes are just here for theoretical completeness,
# and they either return Uninferable or raise InferenceError.
for ast_node in ast_nodes[11:28]:
for ast_node in ast_nodes[11:31]:
with pytest.raises(InferenceError):
next(ast_node.infer())

Expand Down Expand Up @@ -449,16 +452,23 @@ def func(a=1, b=2):

func.__reduce_ex__ #@
func.__lt__ #@
func.__le__ #@
func.__eq__ #@
func.__ne__ #@
func.__ge__ #@
func.__gt__ #@
func.__format__ #@
func.__delattr___ #@
func.__delattr__ #@
func.__getattribute__ #@
func.__hash__ #@
func.__dir__ #@
func.__class__ #@

func.__setattr__ #@
func.__builtins__ #@
func.__getstate__ #@
func.__init_subclass__ #@
func.__type_params__ #@
''',
module_name="fake_module",
)
Expand Down Expand Up @@ -513,14 +523,10 @@ def func(a=1, b=2):

# The following nodes are just here for theoretical completeness,
# and they either return Uninferable or raise InferenceError.
for ast_node in ast_nodes[11:26]:
for ast_node in ast_nodes[11:34]:
inferred = next(ast_node.infer())
assert inferred is util.Uninferable

for ast_node in ast_nodes[26:27]:
with pytest.raises(InferenceError):
inferred = next(ast_node.infer())

def test_empty_return_annotation(self) -> None:
ast_node = builder.extract_node(
"""
Expand Down