Make type.__new__()
raise clear errors instead of returning None
#2851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR improves error reporting for
type.__new__()
validation by replacing silentNone
returns with descriptiveInferenceError
exceptions. Previously, whentype.__new__()
received invalid arguments (wrong metaclass type, invalid name, bad bases, etc.), the code would returnNone
without explanation. Now it raisesInferenceError
with clear messages like"type.new() requires a class for metaclass"
or"type.new() requires 4 arguments, got 3"
. This makes debugging easier and brings the validation in line with other astroid error handling patterns. All existing tests pass without modification since they already expectedInferenceError
for these cases.This is part of the on-going work in PR #2847.