Skip to content

Suppress too-many-ancestors for ModelViewSets #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Suppress too-many-ancestors for ModelViewSets #365

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d153369
Suppress too-many-ancestors for ModelViewSets
jhhayashi Jul 7, 2022
af53449
Add test
jhhayashi Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@
* [naquiroz](https://github.com/naquiroz)
* [john-sandall](https://github.com/john-sandall)
* [dineshtrivedi](https://github.com/dineshtrivedi)
* [jhhayashi](https://github.com/jhhayashi)
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ This plugin is disabled by default! To enable it::
Contributing
------------

Please feel free to add your name to the ``CONTRIBUTORS.rst`` file if you want to
Please feel free to add your name to the ``CONTRIBUTORS.md`` file if you want to
be credited when pull requests get merged. You can also add to the
``CHANGELOG.rst`` file if you wish, although we'll also do that when merging.

Expand Down
8 changes: 8 additions & 0 deletions pylint_django/augmentations/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,6 +895,14 @@ def apply_augmentations(linter):
IsClass("django.views.generic.edit.ProcessFormView"),
)

# ModelViewSet also suffers from too many ancestors
suppress_message(
linter,
MisdesignChecker.visit_classdef,
"too-many-ancestors",
IsClass("rest_framework.viewsets.ModelViewSet"),
)

# model forms have no __init__ method anywhere in their bases
suppress_message(
linter,
Expand Down