Activate mypy in pre-commit #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 86.96% 87.82% +0.86%
==========================================
Files 33 34 +1
Lines 399 419 +20
Branches 81 85 +4
==========================================
+ Hits 347 368 +21
Misses 48 48
+ Partials 4 3 -1
☔ View full report in Codecov by Sentry. |
stdedos
reviewed
Oct 15, 2023
Pierre-Sassoulas
force-pushed
the
pre-commit-pylint
branch
from
865b9fc to
6619f76
Compare
stdedos
force-pushed
the
pre-commit-mypy
branch
from
18d73a3 to
4d9c8a0
Compare
Pierre-Sassoulas
force-pushed
the
pre-commit-pylint
branch
from
b92227b to
0816fc3
Compare
Pierre-Sassoulas
force-pushed
the
pre-commit-mypy
branch
from
4d9c8a0 to
33d1313
Compare
Oooh damn 😓 Now I see what you meant. Nothing warned me that |
|
Heeey - apparently not blocked (and not a total disaster) |
Most of the issues are "almost clear-cut", except the astroid stuff - `pylint_pytest/checkers/class_attr_loader.py`. Those were mostly placated (but hopefully done right). Additionally, add some sanity features to `BasePytestTester`: * Marked class as `ABC` * Enforce subclasses to initialize `MSG_ID` Mostly both of those changes are "aesthetical", and do not contribute to strict guarantees of behavior, or type assertions. But at least `pytest` cries loudly when used wrong - so that's something. Signed-off-by: Stavros Ntentos <[email protected]>
stdedos
force-pushed
the
pre-commit-mypy
branch
from
7f0bd78 to
25c0b9a
Compare
... and `f{msg_id=}`
Signed-off-by: Stavros Ntentos <[email protected]>
stdedos
force-pushed
the
pre-commit-mypy
branch
from
25c0b9a to
b8ce4ad
Compare
|
Actually we'll just have to revert b8ce4ad |
stdedos
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting because this will also be easier if we can do
from __future__ import annotationsafter python 3.6 / 3.7 is dropped.