Move deprecated 'tool.setuptools.license-files', remove license classifier#10289
Move deprecated 'tool.setuptools.license-files', remove license classifier#10289Pierre-Sassoulas merged 7 commits intopylint-dev:mainfrom
Conversation
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Thank you for the merge request. We can also remove setup.cfg and the comment about it now : setuptools handle pyproject'toml.(I did it in astroid yesterday)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10289 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 175 175
Lines 19074 19074
=======================================
Hits 18286 18286
Misses 788 788 🚀 New features to boost your workflow:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-10289-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c8c96d20cde3552a79858c7456bb1483bf83d633
# Push it to GitHub
git push --set-upstream origin backport-10289-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.xThen, create a pull request where the |
|
I take it release is coming next? :) |
|
Yes, it seems to be affecting pre-commit so we need a patch release to fix that. |
…ifier (#10289) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
…ifier (#10289) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
## Link to Issue or Slack thread pylint-dev/pylint#10289 ## Why is this change necessary? pylint pre-commit hook was erroring on install Trying to run copier updates in devcontainers on windows hosts was sometimes having issues ## How does this change address the issue? Pins a patched version of pylint Creates a helper script that can be run to reclone all the files inside the devcontainer on a windows host. ## What side effects does this change have? None ## How is this change tested? In several child and grandchild repositories ## Other Added some misc versions to context.py
|
Should an upper version limit not be specified for setup-tools to avoid having pylint break without version upstep again? Line 4 in a3e5bef |
|
Yes, feel free to shoot a PR @Siebe-Nijs |
When using the latest packaging==24.2, this no longer installs due to pypa/setuptools#4837
and I get the expected error:
Type of Changes
Description
Refs #XXXX
Closes #10290
Refs #10292