Add new checker and bare-name-capture-pattern message.
#10424
+125
β1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10424 +/- ##
==========================================
- Coverage 95.86% 95.85% -0.02%
==========================================
Files 176 177 +1
Lines 19155 19197 +42
==========================================
+ Hits 18363 18401 +38
- Misses 792 796 +4
π New features to boost your workflow:
|
mbyrnepr2
commented
Jun 12, 2025
mbyrnepr2
force-pushed
the
7128_remaining_patterns_unreachable
branch
from
f1ca097 to
0e5ef7c
Compare
mbyrnepr2
changed the title
remaining-patterns-unreachable checker.unreachable-match-patterns message and new checker.
DanielNoord
previously approved these changes
Jun 17, 2025
Pierre-Sassoulas
previously approved these changes
Aug 2, 2025
This comment has been minimized.
This comment has been minimized.
``unreachable-match-patterns``. This will emit an error message when a name capture pattern is used in a match statement which would make the remaining patterns unreachable. This code is a SyntaxError at runtime. Closes pylint-dev#7128
for more information, see https://pre-commit.ci
β¦ 3.10 or higher.
Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Jacob Walls <[email protected]>
ID. (pylint/script/get_unused_message_id_category.py).
text in the checker code.
The example intentionally contains a `SyntaxError` which will also raise a `SyntaxError` from Ruff.
Co-authored-by: Pierre Sassoulas <[email protected]>
mbyrnepr2
force-pushed
the
7128_remaining_patterns_unreachable
branch
from
ad3ec16 to
26a0f0a
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Pierre Sassoulas <[email protected]>
mbyrnepr2
changed the title
unreachable-match-patterns message and new checker.bare-name-capture-pattern message.
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
previously approved these changes
Aug 7, 2025
Co-authored-by: Jacob Walls <[email protected]>
This comment has been minimized.
This comment has been minimized.
cdce8p
requested changes
Aug 9, 2025
There was a problem hiding this comment.
Thanks for working on it @mbyrnepr2! This looks like a great addition.
I saw the discussion where the error should be emitted. Just to provide one more data point, pylance has a similar error message: Irrefutable pattern is allowed only for the last case statement which is emitted for the cases which currently trigger the check.
There is also another message Pattern will never be matched for subject type "Never" for the second and third cases but that's likely based on the type inference result.
Co-authored-by: Marc Mueller <[email protected]>
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 034d78f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This will emit an error message when a name capture pattern is used in a match statement which would make the remaining patterns unreachable. This code is a SyntaxError at runtime.
Closes #7128