Skip to content

Remove support for nmp as import alias for numpy #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

Remove support for nmp as import alias for numpy #10583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25a8aff
Remove support for nmp as import alias for numpy
cdce8p Sep 22, 2025
90d86ad
Update doc/whatsnew/fragments/10583.breaking
cdce8p Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whatsnew/fragments/10583.breaking
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Removed support for ``nmp.NaN`` alias for ``numpy.NaN`` being recognized in ':ref:`nan-comparison`'. Use ``np`` or ``numpy`` instead.

Refs #10583
2 changes: 1 addition & 1 deletion pylint/checkers/base/comparison_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def _is_float_nan(node: nodes.NodeNG) -> bool:
def _is_numpy_nan(node: nodes.NodeNG) -> bool:
match node:
case nodes.Attribute(attrname="NaN", expr=nodes.Name(name=name)):
return name in {"numpy", "nmp", "np"}
return name in {"numpy", "np"}
return False

def _is_nan(node: nodes.NodeNG) -> bool:
Expand Down
Loading