Fix flagging undeprecated importlib.resources functions #10595

Akshay9715 · 2025-09-29T08:34:32Z

Type of Changes

	Type
✓	🐛 Bug fix
✓	✨ New feature

Description

Refs #10593

Closes #10593

Removed read_text from the list of deprecated functions in pylint/checkers/stdlib.py.
Added a new test in tests/checkers/unittest_stdlib.py:

def test_importlib_read_text_not_deprecated(self) -> None:
    """Ensure importlib.resources.read_text is NOT flagged as deprecated."""
    assign_node = astroid.extract_node("""
from importlib.resources import read_text
data = read_text("mypkg", "file.txt")
    """)
    call_node = assign_node.value  # Extract the Call node from the assignment
    with self.assertNoMessages():
        self.checker.visit_call(call_node)

…d test

DanielNoord

Could you add a changelog entry? Our documentation explains how to do this :)

pylint/checkers/stdlib.py

tests/checkers/unittest_stdlib.py

codecov · 2025-09-29T09:03:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.95%. Comparing base (0871a4d) to head (cbb3a43).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10595   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         176      176           
  Lines       19476    19476           
=======================================
  Hits        18689    18689           
  Misses        787      787

Files with missing lines	Coverage Δ
pylint/checkers/stdlib.py	`96.33% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cdce8p · 2025-09-29T09:35:53Z

pylint/checkers/stdlib.py

            "importlib.resources.contents",
            "importlib.resources.is_resource",
            "importlib.resources.open_binary",
            "importlib.resources.open_text",
            "importlib.resources.path",
            "importlib.resources.read_binary",
-            "importlib.resources.read_text",
+            # "importlib.resources.read_text", #un-deprecated in Python 3.13


Please also check if any other ones from importlib.resources are falsely marked as deprecated as well. https://docs.python.org/3/library/importlib.resources.html

I believe everything except importlib.resources.contents could be removed and the deprecation of contents was moved from 3.9 to 3.11.

…dev#10595)

doc/whatsnew/fragments/10595.bugfix.rst

cdce8p · 2025-09-29T11:11:15Z

pylint/checkers/stdlib.py

            "binascii.a2b_hqx",
            "binascii.rlecode_hqx",
            "binascii.rledecode_hqx",
            "importlib.resources.contents",


This should be moved to (3, 11, 0) as the deprecation was delayed.
https://docs.python.org/3/library/importlib.resources.html#importlib.resources.contents

DanielNoord

You'll need to make some small changes to the Changelog for the CI to agree with it. Is the error clear enough for you?

Akshay9715 · 2025-09-30T15:14:05Z

You'll need to make some small changes to the Changelog for the CI to agree with it. Is the error clear enough for you?

I’ve tried a few ways to update the Changelog to satisfy the CI, but I’m still not sure what the exact format or placement should be. Could you please guide me on how to update the Changelog so that the pre-commit CI passes?

doc/whatsnew/fragments/10593.false_positive

cdce8p

Just two minor comments.

cdce8p · 2025-09-30T19:35:37Z

doc/whatsnew/fragments/10593.false_positive

+No longer flag undeprecated functions in ``importlib.resources`` as deprecated.
+
+Closes #10593


Would you mind moving this to 10593.false_positive. That might be an even better fit.

Sorry for the confusion.

cdce8p · 2025-09-30T19:37:13Z

pylint/checkers/stdlib.py

        (3, 11, 0): {
            "locale.getdefaultlocale",
            "locale.resetlocale",
            "re.template",
            "unittest.findTestCases",
            "unittest.makeSuite",
            "unittest.getTestCaseNames",
            "unittest.TestLoader.loadTestsFromModule",
            "unittest.TestLoader.loadTestsFromTestCase",
            "unittest.TestLoader.getTestCaseNames",
            "unittest.TestProgram.usageExit",
+            "importlib.resources.contents",


I think the idea is to have these entries sorted alphabetically, though I realize that's not done consistently. Would you mind moving importlib.resources.contents to the correct place at least?

✅ Renamed changelog fragment to 10593.false_positive as suggested.

✅ Moved importlib.resources.contents into alphabetical order.

…nts entry

for more information, see https://pre-commit.ci

github-actions · 2025-10-02T06:02:11Z

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit cbb3a43

cdce8p

Thanks @Akshay9715 👍🏻

(cherry picked from commit f941edd)

Fix: remove importlib.resources.read_text from deprecated list and ad…

c3d7a7c

…d test

DanielNoord reviewed Sep 29, 2025

View reviewed changes

pylint/checkers/stdlib.py Outdated Show resolved Hide resolved

tests/checkers/unittest_stdlib.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

cdce8p reviewed Sep 29, 2025

View reviewed changes

Akshay9715 added a commit to Akshay9715/pylint that referenced this pull request Sep 29, 2025

Fix: remove falsely deprecated importlib.resources functions (pylint-…

18b379d

…dev#10595)

Akshay9715 force-pushed the fix-importlib-deprecation branch from 67893df to 18b379d Compare September 29, 2025 10:53

Fix: remove falsely deprecated importlib.resources functions (pylint-…

6ea0e27

…dev#10595)

Akshay9715 force-pushed the fix-importlib-deprecation branch from 0b2752d to 6ea0e27 Compare September 29, 2025 11:11

cdce8p reviewed Sep 29, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Pierre-Sassoulas added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/4.0.x labels Sep 29, 2025

Pierre-Sassoulas added this to the 3.3.9 milestone Sep 29, 2025

This comment has been minimized.

Sign in to view

Fix: Adjust stdlib deprecations

ee70de3

Akshay9715 force-pushed the fix-importlib-deprecation branch 4 times, most recently from 135f947 to ee70de3 Compare September 30, 2025 12:28

This comment has been minimized.

Sign in to view

Akshay9715 force-pushed the fix-importlib-deprecation branch 3 times, most recently from 9158d44 to ee70de3 Compare September 30, 2025 13:02

This comment has been minimized.

Sign in to view

DanielNoord reviewed Sep 30, 2025

View reviewed changes

cdce8p reviewed Sep 30, 2025

View reviewed changes

doc/whatsnew/fragments/10593.false_positive Show resolved Hide resolved

Akshay9715 force-pushed the fix-importlib-deprecation branch 2 times, most recently from 99bddb2 to ee70de3 Compare September 30, 2025 15:47

Akshay9715 force-pushed the fix-importlib-deprecation branch from 1ad0861 to ee70de3 Compare September 30, 2025 16:01

Rename changelog fragment to 10593.bugfix and fix format

b8a5155

Akshay9715 force-pushed the fix-importlib-deprecation branch from ed879b1 to b8a5155 Compare September 30, 2025 16:22

This comment has been minimized.

Sign in to view

DanielNoord requested a review from cdce8p September 30, 2025 18:01

cdce8p reviewed Sep 30, 2025

View reviewed changes

Fix changelog fragment name and alphabetize importlib.resources.conte…

d68a541

…nts entry

Akshay9715 force-pushed the fix-importlib-deprecation branch from 55ab345 to d68a541 Compare September 30, 2025 21:07

[pre-commit.ci] auto fixes from pre-commit.com hooks

cbb3a43

for more information, see https://pre-commit.ci

DanielNoord requested a review from cdce8p October 2, 2025 05:37

cdce8p approved these changes Oct 2, 2025

View reviewed changes

cdce8p changed the title ~~Fix: importlib.resources.read_text not flagged as deprecated~~ Fix flagging undeprecated importlib.resources functions Oct 2, 2025

cdce8p merged commit f941edd into pylint-dev:main Oct 2, 2025
44 checks passed

cdce8p temporarily deployed to Backport October 2, 2025 16:16 — with GitHub Actions Inactive

pylint-backport bot pushed a commit that referenced this pull request Oct 2, 2025

Fix flagging undeprecated importlib.resources functions (#10595)

943a6ce

(cherry picked from commit f941edd)

pylint-backport bot mentioned this pull request Oct 2, 2025

[Backport maintenance/3.3.x] Fix flagging undeprecated importlib.resources functions #10605

Merged

Pierre-Sassoulas added the Backported label Oct 12, 2025

Pierre-Sassoulas temporarily deployed to Backport October 12, 2025 15:26 — with GitHub Actions Inactive

Pierre-Sassoulas removed the backport maintenance/4.0.x label Oct 12, 2025

		No longer flag undeprecated functions in ``importlib.resources`` as deprecated.

		Closes #10593

Uh oh!

Fix flagging undeprecated importlib.resources functions #10595

Fix flagging undeprecated importlib.resources functions #10595

Uh oh!

Conversation

Akshay9715 commented Sep 29, 2025

Type of Changes

Description

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

cdce8p Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cdce8p Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

Akshay9715 commented Sep 30, 2025

Uh oh!

Uh oh!

This comment has been minimized.

cdce8p left a comment

Choose a reason for hiding this comment

Uh oh!

cdce8p Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

cdce8p Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Akshay9715 Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

cdce8p left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 29, 2025 •

edited

Loading

cdce8p Sep 29, 2025 •

edited

Loading