Skip to content

Conversation

@pylipp
Copy link
Owner

@pylipp pylipp commented Feb 3, 2026

  • Show warning if not using sqlite database type
  • More info about config filepath
  • Update changelog

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 38f3a5f on tinydb-warning
into cc069ee on master.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a deprecation warning to encourage users to migrate from TinyDB to SQLite database backend before the default changes in v2.0. The warning is displayed whenever a user runs a command (except migrate-pockets) with a non-sqlite database type configured.

Changes:

  • Add warning message when using non-sqlite database types, informing users about the upcoming v2.0 default change
  • Add filepath property to Configuration class to provide access to the config file path
  • Mock warning calls in existing test cases to prevent test failures
  • Add comprehensive test for the warning message content
  • Update plugin test to explicitly set database_type to sqlite
  • Update changelog to document the warning feature

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
financeager/cli.py Adds database type check and warning message after migrate-pockets early return
financeager/config.py Adds filepath property and CONFIG_FILEPATH import for use in warning message
test/test_cli.py Mocks warning logger in test classes and adds test_tinydb_warning test case; updates plugin test config
Changelog.md Updates entry for #271 to mention the warning feature and adds PR #276 reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pylipp pylipp merged commit 8a954a5 into master Feb 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants