Skip to content

Vaan/feature/feature collection#690

Open
Intybyte wants to merge 7 commits intomasterfrom
vaan/feature/feature-collection
Open

Vaan/feature/feature collection#690
Intybyte wants to merge 7 commits intomasterfrom
vaan/feature/feature-collection

Conversation

@Intybyte
Copy link
Member

@Intybyte Intybyte commented Feb 23, 2026

Fixes #683
Fixes #665
Fixes #653
Fixes #39

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just feels like a bad way to implement this imo. There’s no perm checks for placement or breaking, its manual place & break which is just prone to issues with other plugins, also you don’t set facing on the blockdata, does this work on all rotations?

I would make the bedroll a normal bed item, prevent placement if its not night time, and then post successful place do most of the existing logic. Then on wake auto break with the actual method and give the bed directly to the player. That way we actually call events properly.

We could also make a RebarBed block interface for onSleep, onWakeup, onSetSpawn which this could use but obv that can happen later (if ever)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any realistic way on why the plugins should interact with the bed roll, but I can open an issue later I don't feel like adding that stuff because it doesn't seem that necessary to me nor I have a clear idea what you are trying to pitch (beside the permission checks)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doing a skim and I think it would be nice if:

  1. There was a display entity line drawn from the origin to where you're currently looking
  2. The tape measure could handle sub-block distances
  3. The distance was shown live in the actionbar/bossbar. This might conflict with WAILA so not sure but maybe worth looking into

If you want to do that here that would be great, otherwise we can open issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what do you mean in 2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what methods should I use to send a display entity line to only the player ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Entity spawn lambda set visible by default to false and then use player#showenitity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bed Roll Glass Breaker Upgraded loupe with less cooldown Tape measure

4 participants