Open
Conversation
OhmV-IR
changed the title
LordIdra
requested changes
Mar 1, 2026
Contributor
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
(Same issue for plant oil furnace)
Plant oil furnace missing recipe (should be pretty damn cheap I think to encourage using this early game)
Plant oil furnace currently has the same appearance as diesel machines which should be changed
Plant oil furnace should have drastically lower fluid consumption (5 mb/s or similar), and I think diesel furnace too tbh (10 mb/s?)
| .build(); | ||
| static { | ||
| RebarItem.register(FluidFurnace.Item.class, PLANT_OIL_FURNACE, PylonKeys.PLANT_OIL_FURNACE); | ||
| PylonPages.FLUID_MACHINES.addItem(PLANT_OIL_FURNACE); |
Contributor
There was a problem hiding this comment.
I think this would fit better under simple machines. (Btw - please move new items under the correct section in PylonItems.java so their guide order can be controlled)
# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonItems.java # src/main/resources/lang/en.yml
OhmV-IR
force-pushed
the
fluid-furnace-refactor
branch
from
edadae5 to
0510e23
Compare
OhmV-IR
changed the title
Contributor
|
letr me know when this is ready for re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors DieselFurnace into a general class that can take in any fluid from config and add the plant oil furnace
Closes #719
I need to test this ig