Conversation
Intybyte
left a comment
Intybyte
left a comment
There was a problem hiding this comment.
Github didn't link some of the issues bw
src/main/java/io/github/pylonmc/pylon/content/machines/experience/LiquidXPBottle.java
Show resolved
Hide resolved
# Conflicts: # src/main/java/io/github/pylonmc/pylon/PylonItems.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml # src/main/resources/researches.yml
There was a problem hiding this comment.
Missing research key
Research is far too expensive - this is most useful early-ish game when you want to save XP. May I suggest 10 points?
Research should probably be called something other than 'experience production' given you are not actually producing XP ('Experience Liquefaction'?)
I suggest the drain, fountain, and fountain spout go in Fluid Machines as there are machines related to XP which are in other categories (i.e. bottler and probably more in future), so having a separate category for XP stuff is a bit confusing
I think the recipes for XP stuff are also too expensive as this is very useful early-game to conserve XP - I would suggest a very cheap recipe here, especially for drain
Diesel/hydraulic bottlers look strange as there's nothing connecting the connection point to the brewing stand
Diesel/hydraulic bottler multiblock is quite weird... might I suggest just having an input hatch underneath instead?
As discussed the drain conversion ratio should probably be nuked
Drain appears to require shimmer pedestals (???)
Experience liquid should probably be green to reflect XP orb color - this is how mods do it
| liquid_xp_bottle: | ||
| name: "Liquid XP Bottle" | ||
| lore: |- | ||
| <arrow> Throw using <insn>Right-Click</insn> to release stored XP | ||
| <arrow> <attr>Stored XP:</attr> %experience-amount% | ||
|
|
||
| liquid_xp_bottle_super: | ||
| name: "Super Liquid XP Bottle" | ||
| lore: |- | ||
| <arrow> Throw using <insn>Right-Click</insn> to release stored XP | ||
| <arrow> <attr>Stored XP:</attr> %experience-amount% | ||
|
|
||
| liquid_xp_bottle_ultra: | ||
| name: "Ultra Liquid XP Bottle" | ||
| lore: |- | ||
| <arrow> Throw using <insn>Right-Click</insn> to release stored XP | ||
| <arrow> <attr>Stored XP:</attr> %experience-amount% |
There was a problem hiding this comment.
How come we have these rather than using bottles o enchanting?
There was a problem hiding this comment.
Bottles O enchanting drop a random amount of XP as per minecraft wiki https://minecraft.fandom.com/wiki/Bottle_o%27_Enchanting
There was a problem hiding this comment.
The average according to the wiki is 7, couldn't we just do that?
There was a problem hiding this comment.
We could, but that's an average and if this is used at small scales it wouldn't be quite fair. Also the liquid xp bottles enable you to do compression for easier storage, so as we get machines that require more xp or output more xp it's the right choice.
There was a problem hiding this comment.
Also if they decide to change the average in an update it would devalue all of the xp bottles produced so I prefer to keep that balancing in our hands
There was a problem hiding this comment.
Yeah but like does the randomness really matter? Like it doesn't have to be perfectly the exact same amount always. It'll balance out with more than like 10 bottles anyway, and I imagine people would be confused as to why we're not giving vanilla xp bottles. They can be louped too which is nice and you can just give them to players without the xp research which is very nice. For storage, an xp bottle can be stacked to 64 which is already very dense so that's not really a concern, also like liquid xp is a fluid you can store it in tanks. The concern about xp bottles being changed is entirely hypothetical and just not something we should worry about imo
There was a problem hiding this comment.
Yeah but like does the randomness really matter? Like it doesn't have to be perfectly the exact same amount always. It'll balance out with more than like 10 bottles anyway, and I imagine people would be confused as to why we're not giving vanilla xp bottles. They can be louped too which is nice and you can just give them to players without the xp research which is very nice. For storage, an xp bottle can be stacked to 64 which is already very dense so that's not really a concern, also like liquid xp is a fluid you can store it in tanks. The concern about xp bottles being changed is entirely hypothetical and just not something we should worry about imo
Yes it does imo, every other plugin always allow exact amounts, and if we don't follow the same way it will make the entirety of the xp system implemented by pylon unreliable from a player perspective.
"it will balance out anyway" doesn't work, and we already have the hammer as an example
Nobody is getting confused over an item with a precise description of the xp amount given
There was a problem hiding this comment.
It's just as a player there is literally no reason to build an xp bottler for the custom xp because the fountain already exists. The idea of the xp bottler was it would give experience bottles, it was meant as another way to obtain a vanilla item not a way to perfectly store and get back the exact amount if xp. Won't die on this hill though whatever
There was a problem hiding this comment.
It's just as a player there is literally no reason to build an xp bottler for the custom xp because the fountain already exists. The idea of the xp bottler was it would give experience bottles, it was meant as another way to obtain a vanilla item not a way to perfectly store and get back the exact amount if xp. Won't die on this hill though whatever
Trading XP, we can also make recipes later on, even though you can trade it with tanks it is more convenient to have it as bottle
4 participants
Closes #745 ,
Closes #744 ,
Closes #743