Polish smeltery by Seggan · Pull Request #863 · pylonmc/pylon

Seggan · 2026-03-08T19:22:51Z

Updated smeltery recipes
Removed Smeltery Caster and made it a separate block called the Casting Unit that requires the fluid piped in
Smeltery Input and Output Hatches now require the correct temperature
Added casts, for casting liquid metals to nuggets, ingots, blocks, sheets, and pipes (pipes use the crafting ratio, so pipe bender is still more efficient)

# Conflicts: # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml

# Conflicts: # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryOutputHatch.java

Intybyte

Reviewed, works ingame, also are we sure we should drop the documenation of said recipes? I mean they are easy to understand even without it

src/main/java/io/github/pylonmc/pylon/content/machines/smelting/CastingUnit.java

src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryHopper.java

Intybyte · 2026-03-16T08:40:59Z

src/main/java/io/github/pylonmc/pylon/recipes/CastingRecipe.java

 import org.bukkit.inventory.ItemStack;
 import org.jetbrains.annotations.NotNull;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.NonNull;


we use jetbrains annotations

src/main/java/io/github/pylonmc/pylon/recipes/CastingRecipe.java

Intybyte · 2026-03-16T09:53:50Z

build.gradle.kts

+    maven("https://repo.codemc.io/repository/maven-releases/") {
+        name = "CodeMC"
+    }


why was this added?

Entitylib was made from implementation to api in another PR, forgot to change it back

Intybyte · 2026-03-16T10:06:14Z

src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryController.java

+
+            for (Entity entity : getBlock().getWorld().getNearbyEntities(box)) {
+                if (!(entity instanceof LivingEntity livingEntity)) continue;
+                livingEntity.damage(damage, DamageSource.builder(DamageType.LAVA).build());


Just save the DamageSource in a static attribute

is it really necessary? this seems fine

AlmostPanda · 2026-03-16T10:45:59Z

Just want to ask, if controller/burner (also diesel burner) switches to lit=true state when active, because currently (stable version, not PR) it does not

Seggan · 2026-03-16T14:40:57Z

Reviewed, works ingame, also are we sure we should drop the documenation of said recipes? I mean they are easy to understand even without it

The docs were wrong even at that point

Seggan · 2026-03-16T14:41:08Z

Just want to ask, if controller/burner (also diesel burner) switches to lit=true state when active, because currently (stable version, not PR) it does not

Oh yeah I can fix that

LordIdra

The molding recipes won't work because a clay ball cannot be used with the manual brick mold. May I suggest that instead of the molding recipes, we just do it how tinker's and similar mods do it, and require you to pour liquid gold or similar over a block, ingot, pipe, etc?

Apologies this took me so long to get to

LordIdra · 2026-03-18T00:27:43Z

src/main/java/io/github/pylonmc/pylon/content/machines/smelting/CastingUnit.java

Would it perhaps be better behaviour here to make this a PylonFluidTank and just accept any (castable) fluid? I was very confused at first when nothing happened after I piped liquid copper into the casting unit, and it feels unintuitive from a UX perspective as it's inconsistent with what every other fluid block does

I initially had it like that but the problem is I'd need a dynamic tank size

you can do that with PylonFluidTank - the capacity can be set after creation. But I think also you could just set a static size of like 2,000 or something like that. or you could do something like the fluid hatch which would be cool, where you have to build a fluid tank casing on top which holds the fluid

Yeah but if I set it to static

idk what's the biggest cast that's ever gonna be used

It can take more fluid than I wanted, so now I have a whole caster of fluid I don't wanna cast

true. tbf someone could just add an 'advanced caster' or something if they need to do that, it's a fairly niche thing, and the fluid hatch approach would allow a lot of fluid to be stored since the later tanks have a lot of capacity. for the second thing - it does encourage the use of the accumulator or a redstone setup which is nice but idk if that's overcomplicating it. I'm conflicted, it would be really nice to be able to see fluid available but I see why maybe this is better, I'm fine with it as-is then I think. though I'd suggest maybe the barrier should change to something else in the GUI since it's always going to be a barrier, which to me indicates something is wrong

LordIdra · 2026-03-18T00:30:20Z

src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryController.java

+
+            for (Entity entity : getBlock().getWorld().getNearbyEntities(box)) {
+                if (!(entity instanceof LivingEntity livingEntity)) continue;
+                livingEntity.damage(damage, DamageSource.builder(DamageType.LAVA).build());


is it really necessary? this seems fine

src/main/java/io/github/pylonmc/pylon/recipes/CastingRecipe.java

LordIdra · 2026-03-18T00:37:33Z

src/main/resources/recipes/pylon/casting.yml

I think bronze smelting should probably be prioritised over these in the guide

Seggan · 2026-03-18T01:47:23Z

The molding recipes won't work because a clay ball cannot be used with the manual brick mold.

That's intentional, you need a diesel one for it

LordIdra · 2026-03-18T01:48:43Z

The molding recipes won't work because a clay ball cannot be used with the manual brick mold.

That's intentional, you need a diesel one for it

gotcha - still, current recipes feel rather strange to me

Seggan added 13 commits March 3, 2026 16:56

Remove caster & rework melting points

c01373a

Fix fluid consumption

613101c

Borken unit

9450ef2

Imrpovde unit

1d518e3

Add all casting recipes

8d61fed

Add casting recipe display

955354d

Fix bloomery dropping

4883836

Add recipes

1cc5272

Add damage

854b7d4

Interpolate color

3dd7ba2

Merge branch 'master' into chore/smeltery

6133740

# Conflicts: # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml

Merge branch 'master' into chore/smeltery

274f47a

# Conflicts: # src/main/java/io/github/pylonmc/pylon/content/machines/smelting/SmelteryOutputHatch.java

Forgot melting recipes

cf2782b

Intybyte requested changes Mar 16, 2026

View reviewed changes

Intybyte linked an issue Mar 17, 2026 that may be closed by this pull request

Smeltery Damage #783

Open

LordIdra requested changes Mar 18, 2026

View reviewed changes

Conversation

Seggan commented Mar 8, 2026

Uh oh!

Intybyte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlmostPanda commented Mar 16, 2026

Uh oh!

Seggan commented Mar 16, 2026

Uh oh!

Seggan commented Mar 16, 2026

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Seggan commented Mar 18, 2026

Uh oh!

LordIdra commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants