Skip to content

Conversation

juanitorduz
Copy link

Trying to help with the pre-commit automation #145 :)

I did some very minor style-related changes to make ruff happy :) This way we can unblock the pre-commit automation

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz
Copy link
Author

juanitorduz commented Dec 22, 2024

Do I need to do some Cargo lock or something? Everything is failing 😅

@aseyboldt
Copy link
Member

Thank you, that constant failing autogenerated PR was a bit annoying :-)
I think the problem is that the pipeline is now trying to build with python 3.13, but the selected version of pyo3 only allows up to 3.12. We need to update pyo3 to fix this, but because of the new free-threaded python builds this requires some code changes. They are already part of #154, and I think that will be ready to merge pretty soon (next year though), so maybe we just wait with this PR until #154 is merged?

I think we can simply delete the notebook by the way, that shouldn't really be in the repo at all at this point.

@juanitorduz
Copy link
Author

Sounds good! Exited about #154 :)

@aseyboldt
Copy link
Member

Sorry I forgot about this PR, but similar changes are now on main.

@aseyboldt aseyboldt closed this Feb 12, 2025
@juanitorduz
Copy link
Author

All good! Exited about this new release !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants