Skip to content

Conversation

aseyboldt
Copy link
Member

Fixes #169

Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. I don't know why github actions are ignoring the hash comment and interpreting # 3.13 as a version number, but given that's the case, you should remove those lines from the ci.yml

3.10
3.11
3.12
# 3.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have to delete the line instead of trying to comment it out. The gha seem to read # 3.13 as a version tag in itself

3.10
3.11
3.12
# 3.13 leave out 3.13 due to a segfault
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also delete this

3.10
3.11
3.12
# 3.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this

@aseyboldt
Copy link
Member Author

I think this is ready for another review.
If you could also check that this actually solves the example of the sporadically failing sampling run, that'd be great. :-)

Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucianopaz lucianopaz merged commit 5111e9b into pymc-devs:main Feb 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PyMC initial point function is not thread safe

2 participants