stan: Fix rng bug for generated quantities and support tuples #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated quantities have their own random number generator. The seed for this generator did not depend on the global seed of the model, so that random stream for two different sampler runs were reusing the same randomness.
|
I unfortunately don't have a ton of time before going away for a week, but the new test looks like it will catch everything, and at first glance the changes look roughly like what I would expect for this sort of thing, if that helps any! If it's still here when I get back I can do a more thorough review |
|
Thanks for having a quick look. |
aseyboldt
force-pushed
the
push-nulszkuppsyk
branch
from
81a89a5 to
ede466e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented arbitrarily nested data structures, but had to flatten them in the trace. Complex values are still split into two variables. I'll see if I can combine those in a follow up PR as a post-processing step.
@WardBrian If you happen to have a bit of time, it would be great if you can have a quick look at the second commit to check if you see anything obviously wrong. But no worries if you are busy.
Fixes #207