Skip to content

move x_angle to plot_kwargs #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

move x_angle to plot_kwargs #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pymc_bart/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,6 @@ def plot_variable_importance( # noqa: PLR0915
labels: Optional[List[str]] = None,
method: str = "VI",
figsize: Optional[Tuple[float, float]] = None,
xlabel_angle: float = 0,
samples: int = 50,
random_seed: Optional[int] = None,
plot_kwargs: Optional[Dict[str, Any]] = None,
Expand Down Expand Up @@ -728,9 +727,6 @@ def plot_variable_importance( # noqa: PLR0915
VI requieres less computation time.
figsize : tuple
Figure size. If None it will be defined automatically.
xlabel_angle : float
rotation angle of the x-axis labels. Defaults to 0. Use values like 45 for
long labels and/or many variables.
samples : int
Number of predictions used to compute correlation for subsets of variables. Defaults to 100
random_seed : Optional[int]
Expand Down Expand Up @@ -898,7 +894,11 @@ def plot_variable_importance( # noqa: PLR0915
alpha=0.1,
color=plot_kwargs.get("color_ref", "grey"),
)
ax.set_xticks(ticks, new_labels, rotation=xlabel_angle)
ax.set_xticks(
ticks,
new_labels,
rotation=plot_kwargs.get("rotation", 0),
)
ax.set_ylabel("R²", rotation=0, labelpad=12)
ax.set_ylim(0, 1)
ax.set_xlim(-0.5, n_vars - 0.5)
Expand Down
Loading