Skip to content

Conversation

@ckrapu
Copy link
Contributor

@ckrapu ckrapu commented Dec 31, 2025

Update log Gaussian Cox process notebook

This PR updates the LGCP notebook for modeling marked point data to conform to the style guide and compatibility with v5.

Relevant issues: #723 #57

Helpful links

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ckrapu ckrapu changed the title Revise cox process Update log Gaussian Cox process notebook Dec 31, 2025
@ckrapu ckrapu marked this pull request as ready for review December 31, 2025 18:55
@ckrapu
Copy link
Contributor Author

ckrapu commented Dec 31, 2025

I used mp_ctx="spawn" for pm.sample to work around an error from sampling multiple chains on a Mac. It wasn't clear to me if this was acceptable for the docs or if there's a preferred solution/workaround.

@ckrapu
Copy link
Contributor Author

ckrapu commented Jan 15, 2026

Any commentary on this?

Copy link
Member

@fonnesbeck fonnesbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! LGTM

@fonnesbeck fonnesbeck merged commit f792cde into pymc-devs:main Jan 15, 2026
2 checks passed
@ckrapu
Copy link
Contributor Author

ckrapu commented Jan 17, 2026

Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants